236 cypress timing error #241
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This last commit shows that the error was still happening, even after moving the API call to earlier in the page loading logic. I thought at first the the double rendering and Effects caused by React StrictMode were causing the error, but I was able to reproduce the error with StrictMode removed. During my testing I was able to consistently reproduce the error, and fixed the error by breaking up the Cypress commands before clicking the button. Given that the refactoring didn't work, I'm going to close this PR and create a new one that just makes the changes to the Cypress test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The e2e Dataset test was sometimes failing, due to asynchronous page updates that happened while the test was running
Which issue(s) this PR closes:
Special notes for your reviewer:
Because of the timing nature of this error, I couldn't reproduce it consistently, so I can't be sure that this change fixes the problem. But I did break down the steps in the test into smaller increments, based on the Cypress recommendations for this type of error. I've run the test a couple of times, and it seems to be working. Note that I've only seen this happen in the Github action, not when running the test locally.
Suggestions on how to test this:
Make sure that the e2e test in the github Action passes. Run it a couple of times to try to trigger the error
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
no
Is there a release notes update needed for this change?:
no
Additional documentation:
https://docs.cypress.io/guides/references/error-messages#cy-failed-because-the-page-updated